feat: access-api createStoreProxy uses patched fetch that will log any non-ok responses (to debug) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that logs unexpected responses with status=530
gobengo
force-pushed
the
1674080303-proxy-log-530
branch
from
5d4a3ef to
6aada8e
Compare
gobengo
changed the title
…which checks for response.ok, and not only handling 530 response statuses
gobengo
changed the title
yusefnapora
approved these changes
Jan 19, 2023
gobengo
pushed a commit
that referenced
this pull request
Jan 19, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.0](access-api-v4.4.0...access-api-v4.5.0) (2023-01-19) ### Features * access-api createStoreProxy uses patched fetch that will log any non-ok responses (to debug) ([#364](#364)) ([e741bc0](e741bc0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
…y non-ok responses (to debug) (#364) …that logs unexpected responses with status=530 Motivation: * gather more info for [this error happening in production](#363 (comment)) Plan * gather info, then revert this PR
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.0](access-api-v4.4.0...access-api-v4.5.0) (2023-01-19) ### Features * access-api createStoreProxy uses patched fetch that will log any non-ok responses (to debug) ([#364](#364)) ([f13f00e](f13f00e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that logs unexpected responses with status=530
Motivation:
Plan