feat: add uploadCAR function #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olizilla
reviewed
Jan 10, 2023
gobengo
reviewed
Jan 10, 2023
alanshaw
pushed a commit
that referenced
this pull request
Jan 11, 2023
🤖 I have created a release *beep* *boop* --- ## [5.3.0](upload-client-v5.2.0...upload-client-v5.3.0) (2023-01-11) ### Features * add uploadCAR function ([#329](#329)) ([6e40e47](6e40e47)) * embedded key resolution ([#312](#312)) ([4da91d5](4da91d5)) ### Bug Fixes * better upload-api service types ([#323](#323)) ([4cfe312](4cfe312)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
The PR adds an `uploadCAR` function to the client. It differs from `Store.add` because it automatically shards the CAR file, calls `Store.add` for each shard and finally registers an upload (using `Upload.add`). This is very similar to `uploadFile` or `uploadDirectory` except it skips the UnixFS encoding step. Once merged, I'll propogate this to the https://github.com/web3-storage/w3cli so that @lanzafame can upload BIG CARs and have them automatically sharded.
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [5.3.0](upload-client-v5.2.0...upload-client-v5.3.0) (2023-01-11) ### Features * add uploadCAR function ([#329](#329)) ([23eeed2](23eeed2)) * embedded key resolution ([#312](#312)) ([45f367d](45f367d)) ### Bug Fixes * better upload-api service types ([#323](#323)) ([640c1ba](640c1ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds an
uploadCARfunction to the client.It differs from
Store.addbecause it automatically shards the CAR file, callsStore.addfor each shard and finally registers an upload (usingUpload.add). This is very similar touploadFileoruploadDirectoryexcept it skips the UnixFS encoding step.Once merged, I'll propogate this to the https://github.com/web3-storage/w3cli so that @lanzafame can upload BIG CARs and have them automatically sharded.