Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nullish coalescing for audience #319

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

alanshaw
Copy link
Member

When explicitly passing null a default value is not set.

@alanshaw alanshaw requested a review from travis December 16, 2022 11:55
@alanshaw
Copy link
Member Author

LGTM 🙈

@alanshaw alanshaw merged commit a1d5ecf into main Jan 25, 2023
@alanshaw alanshaw deleted the fix/use-nullish-coalescing-audience branch January 25, 2023 15:30
olizilla pushed a commit that referenced this pull request Jan 31, 2023
🤖 I have created a release *beep* *boop*
---


##
[5.4.0](upload-client-v5.3.0...upload-client-v5.4.0)
(2023-01-30)


### Features

* update @ucanto/* to ~4.2.3
([#405](#405))
([50c0c80](50c0c80))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([71cbeb7](71cbeb7))


### Bug Fixes

* use nullish coalescing for audience
([#319](#319))
([a1d5ecf](a1d5ecf))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
hugomrdias pushed a commit that referenced this pull request Jan 31, 2023
When explicitly passing `null` a default value is not set.
gobengo pushed a commit that referenced this pull request Apr 11, 2023
When explicitly passing `null` a default value is not set.
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[5.4.0](upload-client-v5.3.0...upload-client-v5.4.0)
(2023-01-30)


### Features

* update @ucanto/* to ~4.2.3
([#405](#405))
([ec39443](ec39443))
* update access-api ucanto proxy to not need a signer
([#390](#390))
([163fb74](163fb74))


### Bug Fixes

* use nullish coalescing for audience
([#319](#319))
([7e90085](7e90085))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
Updates all the deps and aligns versions so we don't have various
version of the multiformat and @ipld/car

Most updates have been generate with a help of `pnpm upgrade
--interactive -r ` command, however for some reason it was failing to
update deps in `examples` directory resulting in multiple versions of
`multiformats` and `@ipld/car`. I end up working around this by manually
changing `package.json`-s of packages that were referencing old
versions.

Co-authored-by: Travis Vachon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant