Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store add capabilities #166

Closed
wants to merge 1 commit into from
Closed

fix: store add capabilities #166

wants to merge 1 commit into from

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Nov 15, 2022

store/add invocation should have at bare minimum link required.

However, perhaps we should make size required given we want to use it for the signed url?

BREAKING CHANGE: store/add capabilities now have required properties

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99f6344
Status: ✅  Deploy successful!
Preview URL: https://f9f6e424.ucan-protocol.pages.dev
Branch Preview URL: https://fix-store-add-caps.ucan-protocol.pages.dev

View logs

BREAKING CHANGE: store/add capabilities now have required properties
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gozala
Copy link
Contributor

Gozala commented Nov 15, 2022

This was fixed in #159 and should not longer be required

@Gozala Gozala closed this Nov 15, 2022
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](storacha/w3ui@solid-uploads-list-v1.2.2...solid-uploads-list-v2.0.0)
(2022-12-15)


### ⚠ BREAKING CHANGES

* core and framework components have changed considerably. Please read
the updated doucmentation.

### Features

* consume access and upload client
([storacha#159](storacha/w3ui#159))
([e36d842](storacha/w3ui@e36d842))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](storacha/w3ui@solid-uploads-list-v1.2.2...solid-uploads-list-v2.0.0)
(2022-12-15)


### ⚠ BREAKING CHANGES

* core and framework components have changed considerably. Please read
the updated doucmentation.

### Features

* consume access and upload client
([storacha#159](storacha/w3ui#159))
([dc086fd](storacha/w3ui@dc086fd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
fforbeck pushed a commit to storacha/upload-service that referenced this pull request Feb 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.17.0](storacha/console@w3console-v1.16.2...w3console-v1.17.0)
(2024-12-18)


### Features

* add Sentry error tracking
([storacha#165](storacha/console#165))
([3e7069a](storacha/console@3e7069a))


### Bug Fixes

* use the same Sentry project for different envs
([storacha#167](storacha/console#167))
([32dd6f8](storacha/console@32dd6f8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants