fix: look for the correct capability in client.capability.upload.get
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was seeing some strange errors in the nft.storage work I'm doing right now and realized it's a result of a copypasta bug in `upload-client` where we query for the wrong capability when putting together this invocation. We missed this in testing because tests use one big proof, which means that asking for `upload/add` is equivalent to asking for `upload/get` - in an ideal world I'd spend a bit of time untangling this but since I'm at the bottom of a stack of shaved yaks I'd like to get this shipped and file an issue to come back to this later.
alanshaw
approved these changes
Apr 11, 2024
vasco-santos
approved these changes
Apr 11, 2024
travis
pushed a commit
that referenced
this pull request
Apr 11, 2024
🤖 I have created a release *beep* *boop* --- ## [12.5.1](w3up-client-v12.5.0...w3up-client-v12.5.1) (2024-04-11) ### Fixes * look for the correct capability in `client.capability.upload.get` ([#1357](#1357)) ([77199fe](77199fe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing some strange errors in the nft.storage work I'm doing right now and realized it's a result of a copypasta bug in
upload-clientwhere we query for the wrong capability when putting together this invocation.We missed this in testing because tests use one big proof, which means that asking for
upload/addis equivalent to asking forupload/get- in an ideal world I'd spend a bit of time untangling this but since I'm at the bottom of a stack of shaved yaks I'd like to get this shipped and file an issue to come back to this later.