feat: add set method to AccountPlan
#1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update test to use new `PlanStorage#initialize` function. The coverage report is reporting that there are now untested functions in `account.js` but I think that's wrong? Would love any ideas for what's going on here...
gobengo
approved these changes
Jan 29, 2024
This was referenced Jan 29, 2024
travis
added a commit
that referenced
this pull request
Jan 29, 2024
🤖 I have created a release *beep* *boop* --- ## [8.2.0](upload-api-v8.1.0...upload-api-v8.2.0) (2024-01-29) ### Features * add `set` method to `AccountPlan` ([#1281](#1281)) ([b94f0d4](b94f0d4)) ### Fixes * one more tweak to the `PlanStorage` interface ([#1280](#1280)) ([5a44565](5a44565)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jan 29, 2024
🤖 I have created a release *beep* *boop* --- ## [12.3.0](w3up-client-v12.2.1...w3up-client-v12.3.0) (2024-01-29) ### Features * add `set` method to `AccountPlan` ([#1281](#1281)) ([b94f0d4](b94f0d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update test to use new
PlanStorage#initializefunction.