fix: thread abort signal through login functions #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we rely on this in console to allow users to cancel login
Gozala
approved these changes
Nov 28, 2023
travis
pushed a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## [11.1.3](w3up-client-v11.1.2...w3up-client-v11.1.3) (2023-11-28) ### Fixes * thread abort signal through login functions ([#1189](#1189)) ([8e908a9](8e908a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
travis
added a commit
to storacha/w3ui
that referenced
this pull request
Nov 28, 2023
this relies on a PR to w3up-client and re-enables functionality we broke with the switch to the new API: storacha/w3up#1189
gobengo
pushed a commit
that referenced
this pull request
Nov 28, 2023
we rely on this in console to allow users to cancel login
gobengo
pushed a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## [11.1.3](w3up-client-v11.1.2...w3up-client-v11.1.3) (2023-11-28) ### Fixes * thread abort signal through login functions ([#1189](#1189)) ([8e908a9](8e908a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we rely on this in console to allow users to cancel login