Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restricting the number of spaces per providers #704

Closed
heyjay44 opened this issue Mar 30, 2023 · 2 comments
Closed

restricting the number of spaces per providers #704

heyjay44 opened this issue Mar 30, 2023 · 2 comments
Milestone

Comments

@heyjay44
Copy link
Contributor

heyjay44 commented Mar 30, 2023

Timing: start work the week of April 10th

Frontend approach: remove option to create a space in the CLI and console
Alternatively, this can be updated in the backend.

@heyjay44 heyjay44 added this to the w3up phase 4 milestone Mar 30, 2023
@heyjay44 heyjay44 mentioned this issue Mar 30, 2023
23 tasks
travis added a commit to storacha/w3ui that referenced this issue Apr 11, 2023
this gives us a soft restriction on the number of spaces a user can create - we'll enforce this server-side in storacha/w3up#704
@gobengo
Copy link
Contributor

gobengo commented Apr 13, 2023

iirc the goal here is to either:

  1. enforce a limit of one provider/add (which results in a 'provision') per space
  2. enforce a limit of one 'provider' across all provisions per space.
    • i.e. it would be ok for a space to have two provider/add invocations result in provisions as long as the two provisions had identical provider (i.e. they were both 'did:web:nft.storage').

For now I prefer number 1. afaik there is no current need for multiple provisions on a space, so it might just be simpler to enforce a 1:1 mapping space<->provision<->provider in the immediate term. (especially considering the following context). Do you have any concerns with that @Gozala ?

The goal as I recall would be to:

  • make it unlikely that any given space 'is registered with different storage providers'
  • (no other critical use case, so doing something simple is fine)

@gobengo
Copy link
Contributor

gobengo commented Apr 14, 2023

I just looked and what I advocated for above is already implemented via #595

@heyjay44 I think that means no more work is required for this backend-wise.

@gobengo gobengo removed their assignment Apr 14, 2023
travis added a commit to storacha/w3ui that referenced this issue Apr 26, 2023
this gives us a soft restriction on the number of spaces a user can
create - we'll enforce this server-side in
storacha/w3up#704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants