Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access/delegate should cap overall delegation size #576

Open
gobengo opened this issue Mar 20, 2023 · 0 comments
Open

access/delegate should cap overall delegation size #576

gobengo opened this issue Mar 20, 2023 · 0 comments

Comments

@gobengo
Copy link
Contributor

gobengo commented Mar 20, 2023

Rationale

  • clients can invoke access/delegate with=space to store some ucan delegations associated with a space
  • but there's currently no checking on size of those delegations
  • we don't know of a use case that requires these delegations to be extremely large, so we should be able to put an upper bound on the size of these invocations without preventing important use cases
  • if would be helpful to have some cap on these, at the very least for doing capacity planning (e.g. for store access-api delegation bytes in R2 not D1 #571)

What should the cap be?

  • No individual delegation can be bigger than 256kB
  • No access/delegate nb.delegations can be bigger than ?
    • Is this important to limit? Or should we perhaps just define an overall invocation size limit (not just for access/delegate), which I think is implicitly already limited to 100Mb due to cf worker request size limit
  • we make these limits configurable and increase as needed
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](storacha/w3ui@solid-uploads-list-v4.0.1...solid-uploads-list-v5.0.0)
(2023-11-21)


### ⚠ BREAKING CHANGES

* pin solid and vue upload packages
([storacha#589](storacha/w3ui#589))

### Features

* add support for getting an account's plan
([storacha#564](storacha/w3ui#564))
([11023a4](storacha/w3ui@11023a4))
* pin solid and vue upload packages
([storacha#589](storacha/w3ui#589))
([2f7707f](storacha/w3ui@2f7707f))
* re-export Service from `react-keyring`
([storacha#577](storacha/w3ui#577))
([308816d](storacha/w3ui@308816d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant