-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce capabilities that upload/* and store/* APIs could use to decide whether to proceed or fail #495
Comments
From @gobengo
|
🤖 I have created a release *beep* *boop* --- ## [4.1.1](storacha/w3ui@vue-keyring-v4.1.0...vue-keyring-v4.1.1) (2023-04-06) ### Bug Fixes * more email type ([storacha#494](storacha/w3ui#494)) ([355e794](storacha/w3ui@355e794)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [4.1.1](storacha/w3ui@vue-keyring-v4.1.0...vue-keyring-v4.1.1) (2023-04-06) ### Bug Fixes * more email type ([storacha#494](storacha/w3ui#494)) ([1c0db4f](storacha/w3ui@1c0db4f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Right now upload/* uses
space/info
capability to decide whether to allow mutations onstore/*
andupload/*
https://github.com/web3-storage/w3protocol/blob/f0b1e737f4d2f1689c5da04ad5408b114928d2fe/packages/access-api/src/service/index.js#L77-L89
I think it was a workaround which we need to fix, so that those APIs would not fail when space is registered through new
provider/add
capability.My suggestion would be to expose two different capabilities
space/store/allocate
that could succeed or fail depending if space has enough storage provided by storage provider.space/upload/use
- That succeeds if space has activeupload/*
capability provider or fail if it has no such provider.The text was updated successfully, but these errors were encountered: