Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove car sync reader #401

Closed
hugomrdias opened this issue Jan 27, 2023 · 0 comments · Fixed by #428
Closed

Remove car sync reader #401

hugomrdias opened this issue Jan 27, 2023 · 0 comments · Fixed by #428
Assignees
@olizilla
Milestone
w3up phase 2

Comments

@hugomrdias
Copy link
Contributor

Now that js-car has a sync reader we dont need to have here anymore.

Ref: ipld/js-car#121 (comment)
@hugomrdias hugomrdias self-assigned this Jan 27, 2023
@hugomrdias hugomrdias added this to the w3up phase 2 milestone Jan 27, 2023
@olizilla olizilla self-assigned this Feb 7, 2023
@hugomrdias hugomrdias removed their assignment Feb 7, 2023
olizilla added a commit that referenced this issue Feb 8, 2023
@olizilla
chore: use CarBufferReader from @ipld/car
c9b7921 
Remove sync car reader code that has moved upstream into [@ipld/car](ipld/js-car#121 (comment))

Fixes #401

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla mentioned this issue Feb 8, 2023
Merged
alanshaw pushed a commit that referenced this issue Mar 27, 2023
@olizilla @gobengo
chore: use CarBufferReader from @ipld/car (#428)
0608cef 
Remove sync car reader code in favour of CarBufferReader that landed
upstream in
[@ipld/car](ipld/js-car#121 (comment))

Fixes #401


❤️

License: MIT
Signed-off-by: Oli Evans <[email protected]>

---------

Signed-off-by: Oli Evans <[email protected]>
Co-authored-by: Benjamin Goering <[email protected]>
Co-authored-by: Alan Shaw <[email protected]>
gobengo added a commit that referenced this issue Apr 11, 2023
@olizilla @gobengo
chore: use CarBufferReader from @ipld/car (#428)
23ea480 
Remove sync car reader code in favour of CarBufferReader that landed
upstream in
[@ipld/car](ipld/js-car#121 (comment))

Fixes #401


❤️

License: MIT
Signed-off-by: Oli Evans <[email protected]>

---------

Signed-off-by: Oli Evans <[email protected]>
Co-authored-by: Benjamin Goering <[email protected]>
Co-authored-by: Alan Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
None yet
Projects
None yet
Milestone
w3up phase 2
Development

Successfully merging a pull request may close this issue.

chore: use CarBufferReader from @ipld/car storacha/w3up
2 participants
@olizilla @hugomrdias