Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voucher/* stuff does not follow the spec #162

Closed
Gozala opened this issue Nov 12, 2022 · 2 comments
Closed

voucher/* stuff does not follow the spec #162

Gozala opened this issue Nov 12, 2022 · 2 comments
Milestone

Comments

@Gozala
Copy link
Contributor

Gozala commented Nov 12, 2022

Current implementation of vourcher/* capabilities does not follow the spec. Maybe things have been changed deliberately, or perhaps it was mistake. I would like to know which one and either update the implementation or a spec.

@Gozala Gozala added this to the w3up phase 1 milestone Nov 12, 2022
@hugomrdias
Copy link
Contributor

I tweaked some things to be more readable (like the nb fields) and to be able to ship something usable.
We can discuss and adjust further to reconcile.

@hugomrdias
Copy link
Contributor

can we move discussion to storacha/specs#5 ?

@heyjay44 heyjay44 modified the milestones: w3up phase 1, w3up phase 2 Dec 15, 2022
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](storacha/w3ui@react-uploads-list-v1.1.2...react-uploads-list-v2.0.0)
(2022-12-15)


### ⚠ BREAKING CHANGES

* core and framework components have changed considerably. Please read
the updated doucmentation.

### Features

* consume access and upload client
([storacha#159](storacha/w3ui#159))
([e36d842](storacha/w3ui@e36d842))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](storacha/w3ui@react-uploads-list-v1.1.2...react-uploads-list-v2.0.0)
(2022-12-15)


### ⚠ BREAKING CHANGES

* core and framework components have changed considerably. Please read
the updated doucmentation.

### Features

* consume access and upload client
([storacha#159](storacha/w3ui#159))
([dc086fd](storacha/w3ui@dc086fd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <[email protected]>
fforbeck pushed a commit to storacha/upload-service that referenced this issue Feb 5, 2025
…oracha#162)

we really don't want to show the plan gate if we just finished Stripe
checkout - sometimes Stripe isn't fast enough with the webhook so this
will help us provide a UX that makes sense even in this case
fforbeck pushed a commit to storacha/upload-service that referenced this issue Feb 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.16.1](storacha/console@w3console-v1.16.0...w3console-v1.16.1)
(2024-12-12)


### Bug Fixes

* make it possible to skip the plan gate after Stripe checkout
([storacha#162](storacha/console#162))
([b399b37](storacha/console@b399b37))
* tweak plan gate query param
([storacha#163](storacha/console#163))
([0ce071e](storacha/console@0ce071e))


### Other Changes

* update copy ([storacha#159](storacha/console#159))
([0253b05](storacha/console@0253b05))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants