Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for submitting blobs to a filecoin pipeline #1408

Closed
Gozala opened this issue Apr 24, 2024 · 3 comments
Closed

Add support for submitting blobs to a filecoin pipeline #1408

Gozala opened this issue Apr 24, 2024 · 3 comments
Assignees

Comments

@Gozala
Copy link
Contributor

Gozala commented Apr 24, 2024

Context

At the moment most of the filecoin pipeline assumes that all content links are CARs, which may not be the case with Blobs. We need to ensure that blobs can go through filecoin pipeline.

What

Submit blobs to the filecoin pipeline

Why

So that content added as blobs can lands on filecoin

@Gozala
Copy link
Contributor Author

Gozala commented Apr 24, 2024

@vasco-santos I think it would make most sense to just extend support to raw cids (as opposed to adding multihash support) mostly because I expect it to be less work and it makes sense as we address content either as a car or as a raw blob. I am also more convinced that equivalence claims should use cids as opposed to cid and multihash.

@vasco-santos
Copy link
Contributor

  1. We need client to side raw CID instead of carCID with filecoin/offer
  2. (we agreed we can do this as follow up) Equivalency claim issued by filecoin pipeline can pick the digest of the received raw CID

vasco-santos added a commit that referenced this issue May 14, 2024
As we previously decided, `filecoin/offer` should receive raw CIDs
#1408 (comment)
so that everything works out of the box and Blobs can be read from
roundabout for validation + from SPs

Co-authored-by: Andrew Gillis <[email protected]>
Co-authored-by: Alan Shaw <[email protected]>
@vasco-santos
Copy link
Contributor

Closing by merging #1450 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants