start testing providerAdd handler

storacha · Feb 28, 2023 · da6adb6 · da6adb6
1 parent 25c4e0e
commit da6adb6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/packages/access-api/src/service/provider-add.js b/packages/access-api/src/service/provider-add.js
@@ -17,6 +17,10 @@ import * as Ucanto from '@ucanto/interface'
 export function createProviderAddHandler() {
   /** @type {ProviderAddHandler} */
   return async (invocation) => {
-    return {}
+    return {
+      error: true,
+      name: 'NotImplemented',
+      message: 'Provider add not implemented yet',
+    }
   }
 }
diff --git a/packages/access-api/test/provider-add.test.js b/packages/access-api/test/provider-add.test.js
@@ -43,7 +43,7 @@ for (const handlerVariant of /** @type {const} */ ([
           .invoke({
             issuer,
             audience: await handlerVariant.audience,
-            with: issuer.did(),
+            with: `did:mailto:example.com:foo`,
             nb: {
               consumer: space.did(),
               provider: 'did:web:web3.storage:providers:w3up-alpha',
@@ -52,11 +52,7 @@ for (const handlerVariant of /** @type {const} */ ([
           .delegate()
       )
       warnOnErrorResult(result)
-      assert.notDeepEqual(
-        result.error,
-        true,
-        'provider/add result should not be error'
-      )
+      assert.deepEqual('name' in result && result.name, 'NotImplemented')
     })
   })
 }
diff --git a/packages/capabilities/src/provider.js b/packages/capabilities/src/provider.js
@@ -34,13 +34,15 @@ export const StorageProvider = literal(
   'did:web:web3.storage:providers:w3up-alpha'
 )
 
+export const AccountDID = DID.match({ method: 'mailto' })
+
 /**
  * Capability can be invoked by an agent to add a provider to a space.
  */
 export const add = base.derive({
   to: capability({
     can: 'provider/add',
-    with: DID,
+    with: AccountDID,
     nb: {
       provider: StorageProvider,
       consumer: URI.match({ protocol: 'did:' }),

diff --git a/packages/capabilities/src/types.ts b/packages/capabilities/src/types.ts
@@ -40,6 +40,9 @@ export type AccessSession = InferInvokedCapability<typeof AccessCaps.session>
 // Provider
 export type Provider = InferInvokedCapability<typeof provider.provider>
 export type ProviderAdd = InferInvokedCapability<typeof provider.add>
+// eslint-disable-next-line @typescript-eslint/no-empty-interface
+export interface ProviderAddSuccess {}
+export type ProviderAddFailure = Ucanto.Failure
 
 // Space
 export type Space = InferInvokedCapability<typeof space>