fix: make plan/get return value is typed properly (#1029)

set up the service with expected types
storacha · Oct 27, 2023 · 075e341 · 075e341
1 parent f6828ec
commit 075e341
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/access-client/src/types.ts b/packages/access-client/src/types.ts
@@ -43,6 +43,9 @@ import type {
   UCANRevoke,
   UCANRevokeSuccess,
   UCANRevokeFailure,
+  PlanGet,
+  PlanGetSuccess,
+  PlanGetFailure,
 } from '@web3-storage/capabilities/types'
 import type { SetRequired } from 'type-fest'
 import { Driver } from './drivers/types.js'
@@ -86,6 +89,9 @@ export interface Service {
   ucan: {
     revoke: ServiceMethod<UCANRevoke, UCANRevokeSuccess, UCANRevokeFailure>
   }
+  plan: {
+    get: ServiceMethod<PlanGet, PlanGetSuccess, PlanGetFailure>
+  }
 }
 
 /**

diff --git a/packages/access-client/test/agent-use-cases.test.js b/packages/access-client/test/agent-use-cases.test.js
@@ -196,11 +196,11 @@ describe('authorizeWaitAndClaim', async function () {
 describe('getAccountPlan', async function () {
   const accountWithAPlan = 'did:mailto:example.com:i-have-a-plan'
   const accountWithoutAPlan = 'did:mailto:example.com:i-have-no-plan'
-
+  const product = 'did:web:test.web3.storage'
   /** @type {Record<Ucanto.DID, {product: Ucanto.DID, updatedAt: string}>} */
   const plans = {
     [accountWithAPlan]: {
-      product: 'did:web:test.web3.storage',
+      product,
       updatedAt: new Date().toISOString(),
     },
   }
@@ -242,6 +242,7 @@ describe('getAccountPlan', async function () {
   it('should succeed for accounts with plans', async function () {
     const result = await getAccountPlan(agent, accountWithAPlan)
     assert(result.ok)
+    assert.equal(result.ok.product, product)
   })
 
   it('should fail for accounts without a plan', async function () {