-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade access client, ucanto and other packages #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necessary to get this all working with the upgraded access client
8 is gr8
the old versions were no longer working, this seems to fix
they are failing in test, but the bit that they fail on (submitting the "Authorize" form) works fine manually - will create an issue to come back and revive.
I think they added these automatically for backwards compatibility, but I think they might be giving codesandbox heartburn, so try removing them
Have filed #531 for re-enabling Vue playwright tests and fixing the codesandbox builds. |
travis
requested review from
alanshaw and
olizilla
and removed request for
alanshaw
July 25, 2023 16:39
alanshaw
approved these changes
Jul 25, 2023
This was referenced Jul 25, 2023
travis
pushed a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](keyring-core-v4.2.0...keyring-core-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [6.0.0](uploader-core-v5.2.0...uploader-core-v6.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](uploads-list-core-v3.1.0...uploads-list-core-v4.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [6.0.0](react-keyring-v5.2.0...react-keyring-v6.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](react-uploader-v4.2.0...react-uploader-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](react-uploads-list-v3.0.1...react-uploads-list-v4.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](vue-keyring-v4.2.0...vue-keyring-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) ### Bug Fixes * inferred type error ([#516](#516)) ([1bf4cf2](1bf4cf2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](vue-uploader-v4.2.0...vue-uploader-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](vue-uploads-list-v3.0.2...vue-uploads-list-v4.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 26, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](solid-keyring-v4.2.0...solid-keyring-v5.0.0) (2023-07-25) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) ### Bug Fixes * inferred type error ([#516](#516)) ([1bf4cf2](1bf4cf2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
pushed a commit
that referenced
this pull request
Jul 26, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](solid-uploader-v4.2.0...solid-uploader-v5.0.0) (2023-07-26) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
added a commit
that referenced
this pull request
Jul 26, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](solid-uploads-list-v3.1.0...solid-uploads-list-v4.0.0) (2023-07-26) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
Jul 26, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](w3console-v1.5.0...w3console-v2.0.0) (2023-07-26) ### ⚠ BREAKING CHANGES * upgrade access client, ucanto and other packages ([#530](#530)) ### Features * upgrade access client, ucanto and other packages ([#530](#530)) ([8e7321b](8e7321b)) ### Bug Fixes * use unified endpoint for staging services ([#528](#528)) ([82ecaf7](82ecaf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to upgrade the access client so that it will stop pointing at
access.web3.storage
and that required ucanto upgrades.Bumping the major version since I'm not sure this is backwards compatible.
I've disabled the playwright tests for the vue examples for now because they were failing in test but not when the example is run manually - upgrading Vue might help but I'd like to do that in followup work.
I've also disabled codesandbox for now because it was failing, possibly because of an unsupported pnpm version - I'm hoping this will simply go away whenever codesandbox upgrades pnpm.