feat: w3console cleanup and updates to packages to support it #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this wasn't as obvious in our vite-based app but I noticed it using the Authenticator component in a new Next.js app
export more types from `keyring-core`, `uploader-core` and dependent packages to reduce `w3console`'s dependencies to just the `@w3ui/react-*` packages
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b18db1:
|
rather than janky Fragment wrapping, fix return type of SpaceEnsurer
This was referenced Apr 27, 2023
travis
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [5.1.0](uploader-core-v5.0.0...uploader-core-v5.1.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](react-uploader-v4.0.1...react-uploader-v4.1.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [5.2.0](react-keyring-v5.1.1...react-keyring-v5.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [1.5.0](w3console-v1.4.1...w3console-v1.5.0) (2023-05-09) ### Features * add warnings about the public and permanent nature of w3up uploads ([#502](#502)) ([6cc58f8](6cc58f8)), closes [#464](#464) * get w3console looking acceptable on mobile ([#500](#500)) ([118cb22](118cb22)) * remove space creator from sidebar ([#509](#509)) ([40bc621](40bc621)) * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](vue-keyring-v4.1.1...vue-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](vue-uploader-v4.0.0...vue-uploader-v4.1.0) (2023-05-09) ### Features * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * tweak READMEs for packages that release-please didn't release right ([#440](#440)) ([845a6b6](845a6b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](solid-keyring-v4.1.0...solid-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * more email type ([#494](#494)) ([355e794](355e794)) * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
travis
added a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](solid-uploader-v4.0.0...solid-uploader-v4.1.0) (2023-05-09) ### Features * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * tweak READMEs for packages that release-please didn't release right ([#440](#440)) ([845a6b6](845a6b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [5.1.0](storacha/w3ui@uploader-core-v5.0.0...uploader-core-v5.1.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.1.0](storacha/w3ui@react-uploader-v4.0.1...react-uploader-v4.1.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [5.2.0](storacha/w3ui@react-keyring-v5.1.1...react-keyring-v5.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](storacha/w3ui@w3console-v1.4.1...w3console-v1.5.0) (2023-05-09) ### Features * add warnings about the public and permanent nature of w3up uploads ([storacha#502](storacha/w3ui#502)) ([ad0632c](storacha/w3ui@ad0632c)), closes [storacha#464](storacha/w3ui#464) * get w3console looking acceptable on mobile ([storacha#500](storacha/w3ui#500)) ([3e512df](storacha/w3ui@3e512df)) * remove space creator from sidebar ([storacha#509](storacha/w3ui#509)) ([d5f5536](storacha/w3ui@d5f5536)) * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@vue-keyring-v4.1.1...vue-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.1.0](storacha/w3ui@vue-uploader-v4.0.0...vue-uploader-v4.1.0) (2023-05-09) ### Features * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * tweak READMEs for packages that release-please didn't release right ([storacha#440](storacha/w3ui#440)) ([9b8a9c8](storacha/w3ui@9b8a9c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@solid-keyring-v4.1.0...solid-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * more email type ([storacha#494](storacha/w3ui#494)) ([1c0db4f](storacha/w3ui@1c0db4f)) * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.1.0](storacha/w3ui@solid-uploader-v4.0.0...solid-uploader-v4.1.0) (2023-05-09) ### Features * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * tweak READMEs for packages that release-please didn't release right ([storacha#440](storacha/w3ui#440)) ([9b8a9c8](storacha/w3ui@9b8a9c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate some learnings from creating a new app from the ground up with some tasks I've been meaning to do for a little while to clean up w3console. This is mostly either:
a) extracting components to their own files OR
b) lifting up types to eliminate 2-level-deep dependencies (ie, allowing w3console to only depend on the
@w3ui/react-*packages rather than pulling in@w3ui/*-coreandmultiformats)NOTE FOR REVIEWERS:
I'm particularly curious whether this change:
https://github.com/web3-storage/w3ui/pull/507/files#diff-b93f102a72fd250d9c7b9411fa0a0e4cb24b5dbe12396017aea5405cecdc371bR9
feels right to reviewers - a user of this library was recently confused by the
Linktype and asked where they could get theCID- I think most users of this library will be happier to get aCIDtype here but I'm ignorant of what implications this might have for return values from the service...