fix: wait for register space before returning from space create onSubmit #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we weren't `await`ing here the space creation UI would flash empty again, which was very confusing
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 63fc726:
|
gobengo
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
those pesky forgotten awaits :/
consider adopting https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-misused-promises.md
travis
pushed a commit
that referenced
this pull request
Mar 24, 2023
🤖 I have created a release *beep* *boop* --- ## [1.2.0](w3console-v1.1.0...w3console-v1.2.0) (2023-03-24) ### Features * updates to ToS and login page ([#447](#447)) ([e62ad96](e62ad96)), closes [#397](#397) ### Bug Fixes * make auth email input text black ([#462](#462)) ([dc8ddca](dc8ddca)) * wait for register space before returning from space create onSubmit ([#463](#463)) ([9b35b2c](9b35b2c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.2.0](storacha/w3ui@w3console-v1.1.0...w3console-v1.2.0) (2023-03-24) ### Features * updates to ToS and login page ([storacha#447](storacha/w3ui#447)) ([fb127e1](storacha/w3ui@fb127e1)), closes [storacha#397](storacha/w3ui#397) ### Bug Fixes * make auth email input text black ([storacha#462](storacha/w3ui#462)) ([89218b5](storacha/w3ui@89218b5)) * wait for register space before returning from space create onSubmit ([storacha#463](storacha/w3ui#463)) ([832fb97](storacha/w3ui@832fb97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we weren't
awaiting here the space creation UI would flash empty again, which was very confusing