Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more docs #368

Merged
merged 2 commits into from
Feb 3, 2023
Merged

fix: add more docs #368

merged 2 commits into from
Feb 3, 2023

Conversation

travis
Copy link
Member

@travis travis commented Feb 3, 2023

release-please doesn't create a release for chores, so my last attempt to create a new keyring-core release failed.

Add some basic docs, and call this a fix to get release-please to do the right thing.

`release-please` doesn't create a release for chores, so my last attempt
to create a new keyring-core release failed.

Add some basic docs, and call this a `fix` to get `release-please` to do the right thing.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 44a8ec6:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

@travis
Copy link
Member Author

travis commented Feb 3, 2023

ok one more try at getting release-please to create a release for keyring-core - @yusefnapora I feel like my description of a Space leaves something to be desired, would love your thoughts on the best way to explain spaces to w3ui users and happy to update this ASAP.

for now, self-merging to get the release process going.

@travis travis merged commit c339d82 into main Feb 3, 2023
@travis travis deleted the fix/release-pretty-please branch February 3, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant