chore: upgrade all the deps #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1234d9e:
|
Gozala
commented
Feb 1, 2023
| @@ -32,10 +32,10 @@ | |||
| "@storybook/testing-library": "^0.0.13", | |||
| "@types/react": "^18.0.26", | |||
| "@types/react-dom": "^18.0.9", | |||
| "@ucanto/interface": "^4.0.3", | |||
| "@ucanto/interface": "^4.2.3", | |||
There was a problem hiding this comment.
I think it would be a good idea for @w3ui/react and perhaps others from the family to re-export same basics like @ucanto/interaface and perhaps some things from multiformats so that they don't need to be imported by the users and deal with dependency problems.
Gozala
commented
Feb 1, 2023
| @@ -1,5 +1,5 @@ | |||
| import React from 'react' | |||
| import { CID } from 'multiformats/cid' | |||
| import * as Link from 'multiformats/link' | |||
There was a problem hiding this comment.
Note: CID still exists but Link is designed to be more abstract and less prone to becoming out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all the deps and aligns versions so we don't have various version of the multiformat and @ipld/car
Most updates have been generate with a help of
pnpm upgrade --interactive -rcommand, however for some reason it was failing to update deps inexamplesdirectory resulting in multiple versions ofmultiformatsand@ipld/car. I end up working around this by manually changingpackage.json-s of packages that were referencing old versions.