wip: first pass at adding a space selector to w3console #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this displays 42 spaces on my localhost, which makes sense... I guess? but I'm getting an error calling setCurrentSpace:
```
agent.js:361 Uncaught (in promise) Error: Agent has no proofs for [object Object].
at _Agent.setCurrentSpace (agent.js:361:13)
at setCurrentSpace (Keyring.tsx:92:17)
```
@olizilla handing the baton to you!
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d93a88:
|
Sometimes a space fails to register - before this patch if you clicked on one of those spaces it would look like you logged out. With these changes we now give the user an opportunity to register the space so that they can start uploading files to it.
take a slightly different approach from the other stories - wrap SpaceList in a component specifically made for StoryBook testing that passes values to a Context Provider and renders the component under test inside the Provider. This lets us craft an interface in StoryBook that will make sense to designers and other folks.
|
this has been incorporated into #268, closing |
travis
added a commit
that referenced
this pull request
Jan 19, 2023
Riffing on #266 - add a space-finder combobox based on https://headlessui.com/react/combobox - updates w3console layout to look fancy  Signed-off-by: Oli Evans <[email protected]> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this displays 42 spaces on my localhost, which makes sense... I guess? but I'm getting an error calling setCurrentSpace:
@olizilla handing the baton to you! next steps (I think? feel free to add):