fix: updates from PR review from @olizilla

storacha · Feb 1, 2023 · 06bf422 · 06bf422
1 parent 72d128b
commit 06bf422
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 40 deletions.
diff --git a/examples/react/playground/.storybook/preview-head.html b/examples/react/playground/.storybook/preview-head.html
@@ -1,3 +1,9 @@
 <script>
   window.global = window;
-</script>
+</script>
+<style>
+  html {
+    /* _no one wants to see times new roman_ - @olizilla */
+    font-family: ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
+  }
+</style>
diff --git a/examples/react/playground/.storybook/preview.js b/examples/react/playground/.storybook/preview.js
@@ -6,4 +6,7 @@ export const parameters = {
       date: /Date$/,
     },
   },
+  backgrounds: {
+    default: 'dark'
+  }
 }
diff --git a/examples/react/playground/src/stories/AuthenticationSubmitted.stories.tsx b/examples/react/playground/src/stories/AuthenticationSubmitted.stories.tsx
@@ -2,19 +2,14 @@ import { AuthenticationSubmitted } from '@w3ui/react'
 import '@w3ui/react/src/styles/authenticator.css'
 
 export default {
-  title: 'w3ui/AuthenticationSubmitted',
+  title: 'w3ui/Authenticator',
   component: AuthenticationSubmitted,
   tags: ['autodocs'],
   argTypes: {
-  },
-  parameters: {
-    backgrounds: {
-      default: 'dark'
-    }
   }
 }
 
-export const Primary = {
+export const Submitted = {
   args: {
   }
 }
diff --git a/examples/react/playground/src/stories/Authenticator.stories.tsx b/examples/react/playground/src/stories/Authenticator.stories.tsx
@@ -6,11 +6,6 @@ export default {
   component: Authenticator,
   tags: ['autodocs'],
   argTypes: {
-  },
-  parameters: {
-    backgrounds: {
-      default: 'dark'
-    }
   }
 }
 

diff --git a/examples/react/playground/src/stories/SpaceCreator.stories.tsx b/examples/react/playground/src/stories/SpaceCreator.stories.tsx
@@ -6,11 +6,6 @@ export default {
   component: SpaceCreator,
   tags: ['autodocs'],
   argTypes: {
-  },
-  parameters: {
-    backgrounds: {
-      default: 'dark'
-    }
   }
 }
 

diff --git a/examples/react/playground/src/stories/SpaceCreatorCreating.stories.tsx b/examples/react/playground/src/stories/SpaceCreatorCreating.stories.tsx
@@ -2,19 +2,14 @@ import { SpaceCreatorCreating } from '@w3ui/react'
 import '@w3ui/react/src/styles/space-creator.css'
 
 export default {
-  title: 'w3ui/SpaceCreatorCreating',
+  title: 'w3ui/SpaceCreator',
   component: SpaceCreatorCreating,
   tags: ['autodocs'],
   argTypes: {
-  },
-  parameters: {
-    backgrounds: {
-      default: 'dark'
-    }
   }
 }
 
-export const Primary = {
+export const Creating = {
   args: {
   }
 }
diff --git a/examples/react/playground/src/stories/Uploader.stories.tsx b/examples/react/playground/src/stories/Uploader.stories.tsx
@@ -8,9 +8,7 @@ export default {
   argTypes: {
   },
   parameters: {
-    backgrounds: {
-      default: 'dark'
-    }
+
   }
 }
 

diff --git a/examples/react/playground/src/stories/UploadsList.stories.tsx b/examples/react/playground/src/stories/UploadsList.stories.tsx
@@ -11,12 +11,7 @@ import '@w3ui/react/src/styles/uploads-list.css'
 export default {
   title: 'w3ui/UploadsList',
   component: UploadsList,
-  tags: ['autodocs'],
-  parameters: {
-    backgrounds: {
-      default: 'dark'
-    }
-  }
+  tags: ['autodocs']
 }
 
 // More on writing stories with args: https://storybook.js.org/docs/7.0/react/writing-stories/args

diff --git a/examples/test/playwright/package.json b/examples/test/playwright/package.json
@@ -4,7 +4,7 @@
   "type": "module",
   "scripts": {
     "serve": "serve ../../",
-    "test": "playwright install && playwright test",
+    "test": "playwright test",
     "test:debug": "playwright test --project=chromium --headed"
   },
   "author": "olzilla",

diff --git a/packages/react/src/SpaceFinder.tsx b/packages/react/src/SpaceFinder.tsx
@@ -24,7 +24,7 @@ export function SpaceFinder ({ spaces, selected, setSelected, className = '' }:
       )
 
   return (
-    <div className={`${className} w3ui-space-finder-wrapper`}>
+    <div className={`${className} w3ui-space-finder`}>
       <Combobox value={selected} onChange={setSelected} by={(a, b) => a.sameAs(b)}>
         <div className='w3ui-space-finder-contents'>
           <div className='w3ui-space-finder-closed'>

diff --git a/packages/react/src/UploadsList.tsx b/packages/react/src/UploadsList.tsx
@@ -5,8 +5,7 @@ import { UploadsList as UploadsListCore } from '@w3ui/react-uploads-list'
 function Uploads ({ uploads }: { uploads?: UploadListResult[] }): JSX.Element {
   if ((uploads === undefined) || (uploads.length === 0)) {
     return (
-      <>
-        <div>
+        <>
           <div className='w3-uploads-list-no-uploads'>
             No uploads
           </div>
@@ -15,8 +14,7 @@ function Uploads ({ uploads }: { uploads?: UploadListResult[] }): JSX.Element {
               Reload
             </UploadsListCore.ReloadButton>
           </nav>
-        </div>
-      </>
+        </>
     )
   } else {
     return (