Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(billing): support blob capabilities #356

Merged
merged 2 commits into from
Apr 24, 2024
Merged

feat(billing): support blob capabilities #356

merged 2 commits into from
Apr 24, 2024

Conversation

alanshaw
Copy link
Member

  • Use the blob allocate receipt to track space size additions.
  • Use blob remove receipt to track space size reductions.

@alanshaw alanshaw force-pushed the feat/billing-support-blob-caps branch from f3608c4 to 989ff31 Compare April 24, 2024 14:54
@alanshaw alanshaw mentioned this pull request Apr 24, 2024
Closed
@seed-deploy Seed Deploy
Copy link

seed-deploy bot commented Apr 24, 2024

View stack outputs

vasco-santos
vasco-santos approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

billing/test/lib/ucan-stream.js Outdated
const receipts = [{
type: 'receipt',
carCid: randomLink(),
invocationCid: randomLink(),
value: {
att: [{
with: await randomDID(),
with: await randomDIDKey(),
can: 'web3.storage/blob/allocate',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, could we use exported .can from capabilities repo instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did reach for that first but then I realised I didn't do it for the rest of them in the other tests and it would be a bigger change. Worth doing in retrospect.

@seed-deploy seed-deploy bot temporarily deployed to pr356 April 24, 2024 15:26 Inactive
@alanshaw alanshaw merged commit 5779161 into main Apr 24, 2024
3 checks passed
@alanshaw alanshaw deleted the feat/billing-support-blob-caps branch April 24, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@travis travis Awaiting requested review from travis

@Gozala Gozala Awaiting requested review from Gozala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @vasco-santos