feat: add receipts endpoint #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/receipts-endpoint
branch
from
dea46e2 to
d9f8591
Compare
vasco-santos
force-pushed
the
feat/receipts-endpoint
branch
from
d9f8591 to
2416f62
Compare
View stack outputs
|
vasco-santos
commented
Nov 13, 2023
| @@ -116,12 +116,12 @@ export const useInvocationStore = (s3client, bucketName) => { | |||
| }) | |||
| const listObject = await s3client.send(listObjectCmd) | |||
| const carEntry = listObject.Contents?.find( | |||
| content => content.Key?.endsWith('.workflow') | |||
| content => content.Key?.endsWith('.out') | |||
There was a problem hiding this comment.
😱 this had a bug, but this code path was not being used. See https://github.com/web3-storage/w3infra/blob/main/docs/ucan-invocation-stream.md#buckets as this first was .workflow but then was iterated to .in and .out
vasco-santos
requested review from
Gozala and
alanshaw
and removed request for
Gozala
vasco-santos
added a commit
to storacha/w3up
that referenced
this pull request
Nov 15, 2023
Adds `getReceipt(taskCid)` support in client after endpoint added into w3filecoin earlier this week storacha/w3infra#275 When you get a CID from an invocation, you can look for its receipt and go through receipt chain if you like from the client :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds receipts endpoint with redirect to workflow bucket where receipt for asked task will be available.
Bucket was made public to accept GETs, you can see the generated policy here . IAM Role has general access to the bucket, while
"Principal": "*"can performGetObject.Integration tests were added to inspect receipt from
filecoin/offerinvocation