feat: deal monitor alert #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
a4d438b to
5d1cb0d
Compare
View stack outputs
|
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
5d1cb0d to
607d4e6
Compare
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
607d4e6 to
802f54b
Compare
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
802f54b to
1222092
Compare
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
1222092 to
50b6eef
Compare
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
50b6eef to
2cb4f7f
Compare
vasco-santos
force-pushed
the
feat/deal-monitor-alert
branch
from
2cb4f7f to
009611c
Compare
|
@alanshaw propagated w3up updates here and this is ready to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRON to monitor deals in progress and trigger alerts if they are taking longer than expectations. I opted for taking this into the API Stack as it ends up not being a role of any of the actors (Aggregator, Dealer, etc).
The Monitor CRON goes through Dealer aggregate store (like the CRON who sees deals are ready to issue receipts), and when aggregates are there for longer than a configured threshold (
AGGREGATE_MONITOR_THRESHOLD_MS), they are inspected. By inspection, we see the date where min piece was ingested and based on alerting thresholds (MIN_PIECE_WARN_THRESHOLD_MS+MIN_PIECE_CRITICAL_THRESHOLD_MS) may add aggregates to alerts as warning or critical alert.We rely on grafana alerting to HTTP POST a payload with the known alerts. This has an integration already with Slack
Needs: