forked from storacha/w3up
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(egress/record): rename capability (#1572) #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR restructures the `usage/record` capability, moving it under the `Space` namespace instead of `Usage`. As part of this change, the `usage/record` definition has been renamed to `space/content/serve/egress/record`, and a new top-level capability, `space/content/serve/*`, has been introduced. - **Namespace Update**: The `usage/record` capability now resides under the `Space` namespace. - **New Naming Convention**: - `space/content/serve/egress/record`: This capability records egress for all served data. - `space/content/serve/*`: New top-level capability, representing general serve actions within the `Space.contentServe` namespace. --------- Signed-off-by: Felipe Forbeck <[email protected]>
alanshaw
approved these changes
Dec 12, 2024
This was referenced Dec 12, 2024
fforbeck
added a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.2](capabilities-v1.1.1...capabilities-v1.1.2) (2024-12-12) ### Fixes * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([98ab50c](98ab50c)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([#97](#97)) ([df8b9a2](df8b9a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fforbeck
added a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.8](upload-api-v1.1.7...upload-api-v1.1.8) (2024-12-12) ### Fixes * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([98ab50c](98ab50c)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([#97](#97)) ([df8b9a2](df8b9a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fforbeck
added a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.6](client-v1.0.5...client-v1.0.6) (2024-12-12) ### Fixes * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([98ab50c](98ab50c)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([#97](#97)) ([df8b9a2](df8b9a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fforbeck
added a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.8](upload-api-v1.1.7...upload-api-v1.1.8) (2024-12-12) ### Fixes * **egress/record:** Remove unnecessary multiplication for ts conversion ([#98](#98)) ([79ac1ab](79ac1ab)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([98ab50c](98ab50c)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([#97](#97)) ([df8b9a2](df8b9a2)) * **egressRecord:** Remove unnecessary multiplication for ts conversion ([storacha#1588](https://github.com/storacha/upload-service/issues/1588)) ([1870202](1870202)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fforbeck
added a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.6](client-v1.0.5...client-v1.0.6) (2024-12-12) ### Fixes * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([98ab50c](98ab50c)) * **egress/record:** rename capability ([storacha#1572](https://github.com/storacha/upload-service/issues/1572)) ([#97](#97)) ([df8b9a2](df8b9a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the
usage/record
capability, moving it under theSpace
namespace instead ofUsage
. As part of this change, theusage/record
definition has been renamed tospace/content/serve/egress/record
, and a new top-level capability,space/content/serve/*
, has been introduced.usage/record
capability now resides under theSpace
namespace.space/content/serve/egress/record
: This capability records egress for all served data.space/content/serve/*
: New top-level capability, representing general serve actions within theSpace.contentServe
namespace.