fix: compatibility with legacy w3up client #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeja
approved these changes
Nov 27, 2024
| @@ -1,5 +1,4 @@ | |||
| import { ed25519 } from '@ucanto/principal' | |||
| import { conclude } from '@storacha/capabilities/ucan' | |||
This was referenced Nov 27, 2024
alanshaw
pushed a commit
that referenced
this pull request
Nov 27, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.4](upload-api-v1.1.3...upload-api-v1.1.4) (2024-11-27) ### Fixes * compatibility with legacy w3up client ([#59](#59)) ([7185046](7185046)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Nov 27, 2024
Peeja
added a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.3](client-v1.0.2...client-v1.0.3) (2024-11-27) ### Fixes * compatibility with legacy w3up client ([#59](#59)) ([7185046](7185046)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
added a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.3](client-v1.0.2...client-v1.0.3) (2024-11-29) ### Fixes * compatibility with legacy w3up client ([#59](#59)) ([7185046](7185046)) ### Other Changes * **main:** release client 1.0.3 ([b0ccad7](b0ccad7)) * **main:** release client 1.0.3 ([#79](#79)) ([7c336f2](7c336f2)) * Revert "chore(main): release client 1.0.3" ([#84](#84)) ([2f354c4](2f354c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fforbeck
pushed a commit
that referenced
this pull request
Dec 19, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.2](upload-client-v1.0.1...upload-client-v1.0.2) (2024-12-02) ### Fixes * compatibility with legacy w3up client ([#59](#59)) ([7185046](7185046)) * jsdoc ([5506c11](5506c11)) * overflow slices ([storacha#1595](https://github.com/storacha/upload-service/issues/1595)) ([949b84a](949b84a)) * thanks prettier ([11e34b4](11e34b4)) * trigger release ([f0f9a56](f0f9a56)) ### Other Changes * prettier ([40ebc05](40ebc05)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
upload-serviceto work with the legacy client (@web3-storage/w3up-client).The new service uses
blob/allocateandblob/acceptcapabilities when talking to storage nodes. For some reason I thought these were not referenced by the client but they are....except via their old namesweb3.storage/blob/allocateandweb3.storage/blob/accept🤦This PR adds additional effects to the
blob/addreceipt, essentially "fake"web3.storage/blob/allocateandweb3.storage/blob/acceptdelegations that contain the same information as theirblob/allocateandblob/acceptcounterparts. It allows old clients to use the old capability names and the new clients to use the new ones.We can remove these additional effects when we are satisfied enough clients have moved to
@storacha/client.