feat: align implementation with receipt 0.2 spec #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
commented
Mar 30, 2023
23 tasks
gobengo
approved these changes
Mar 30, 2023
gobengo
changed the title
Merged
This was referenced Apr 11, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change that happened since last iteration is that
Outcomeused be a separate block and now it is just a field onReceiptblock https://github.com/ucan-wg/invocation/blob/v0.2/README.md#82-receiptLess obvious change that happened is addition of
ReceiptBuliderwhich is basically a placeholder structure so you could defer issuing a receipt. Currently it is only used byissuefunction, but it is set up such that you could allow passing different codecs and hashers. I hope to do something similar forDelegationas well in the future so that you could send a request withaccept: application/jsonand ucanto will respond in JSON as opposed to cbors in the the car.