feat(tracing): enable setting a sampling ratio for tracing #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
requested changes
Jan 6, 2025
|
Freeway handles about 2-5m requests per hour, 2.12b over the last month, so 1% of that should use up about 20% of our Honeycomb allocation - seems reasonable for now, and we can knock it down an order of magnitude if we need the space for another app. 
|
Co-authored-by: ash <[email protected]>
Co-authored-by: ash <[email protected]>
alanshaw
approved these changes
Jan 7, 2025
|
@travis lowered the ratio to 0.0005 cause I now see that the billing is per span and I think we're looking at 20 spans or so per trace. |
hannahhoward
pushed a commit
that referenced
this pull request
Jan 9, 2025
🤖 I have created a release *beep* *boop* --- ## [2.23.0](v2.22.1...v2.23.0) (2025-01-09) ### Features * **tracing:** enable setting a sampling ratio for tracing ([#143](#143)) ([241545f](241545f)) ### Bug Fixes * **freeway:** enable tracing properly and resolve fetch issue ([#140](#140)) ([c60037d](c60037d)) * handle options req for cors preflight ([#137](#137)) ([79de5b1](79de5b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Set us up to enable traces in our prod w3s.link environment
Implementation
Essentially, to enable tracing in prod, we need to cut down on number of requests we sample traces for. This PR introduces the simplest form of sampling: head sampling, where we simply only enable traces on a small set of samples
The next step would be to do some kind of tail sampling -- sent traces on error response codes for example.
For now I set the sampling ratio for prod to 1% -- could use some guidance from @travis who might have the best sense of how many requests we're talking about -- our current Honeycomb account supports 100 million per month.