Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc: egress tracking #37
base: main
Are you sure you want to change the base?
rfc: egress tracking #37
Changes from 1 commit
2318425
3f32a74
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it's at least moderately important to have those signed receipts - I suspect customers are going to want as much information as possible about what they're being charged for. We might be able to just aggregate metrics around them and store in Glacier for the sake of minimizing costs, but having signed receipts for each request feels like something that will eventually be fairly useful?
@alanshaw is right that there will be a LOT of them and they'll probably have different retention policies than most other UCAN invocation receipts, though for the sake of getting this shipped we might want to use the upload API service for now and add a new service later?
It definitely might be worth adding a new service that uses a similar invocation processing pipeline and different retention policies - ideally we'd move egress tracking receipts from S3 hot storage to Glacier pretty quickly for these, faster than for most other receipts we store.