Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repo): vale docs review #2352

Closed
wants to merge 2 commits into from
Closed

Conversation

heitortsergent
Copy link
Contributor

@heitortsergent heitortsergent commented Nov 29, 2022

Fixes https://github.com/stoplightio/platform-docs/issues/603.

Checklist

  • Tests added / updated
  • Docs added / updated

Vale review of the Spectral docs using the Stoplight platform-docs Vale style guide.

pamgoodrich
pamgoodrich previously approved these changes Dec 1, 2022
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/getting-started/1-concepts.md Outdated Show resolved Hide resolved
docs/getting-started/2-installation.md Outdated Show resolved Hide resolved
docs/guides/8-continuous-integration.md Outdated Show resolved Hide resolved
docs/migration-guides/5.0.md Outdated Show resolved Hide resolved
docs/migration-guides/6.0.md Outdated Show resolved Hide resolved
docs/migration-guides/6.0.md Outdated Show resolved Hide resolved
docs/migration-guides/6.0.md Outdated Show resolved Hide resolved
pamgoodrich
pamgoodrich previously approved these changes Dec 13, 2022
@@ -1,20 +1,20 @@
## Recommended or All

Rules by default are considered "recommended" (equivalent to a rule having) `recommended: true` but they can also be marked as not recommended with `recommended: false`. This can help scenarios like rolling out rulesets across API landscapes with a lot of legacy APIs which might have a hard time following every rule immediately. A two-tier system for rules can be helpful here, to avoid requiring several rulesets for this basic use case.
Rules by default are considered "recommended" (equivalent to a rule having) `recommended: true` but they can also be marked as not recommended with `recommended: false`. This can help scenarios like rolling out rulesets across API landscapes with a lot of legacy APIs which might have a hard time following every rule immediately. A two-tier system for rules can be helpful here, to avoid requiring multiple rulesets for this basic use case.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that.

@heitortsergent heitortsergent marked this pull request as ready for review December 14, 2022 15:34
@heitortsergent heitortsergent requested review from a team as code owners December 14, 2022 15:34
@P0lip P0lip force-pushed the develop branch 3 times, most recently from cf3ae99 to 761c65a Compare December 14, 2022 15:55
@heitortsergent heitortsergent mentioned this pull request Dec 14, 2022
2 tasks
@heitortsergent heitortsergent deleted the docs/vale-review branch December 14, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants