fix(cli): output to stdout not working with multiple output formatters #2044
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,9 +12,13 @@ jest.mock('../../services/linter'); | |
|
|
||
| function run(command: string) { | ||
| const parser = yargs.command(lintCommand).help(); | ||
| return new Promise((resolve, reject) => { | ||
| parser.parse(command, (err: Error, argv: unknown, output: string) => { | ||
| if (err) { | ||
| reject(`${err.message}\n${output}`); | ||
| } else { | ||
| resolve(output); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
|
|
@@ -60,10 +64,9 @@ describe('lint', () => { | |
| process.stdin.isTTY = isTTY; | ||
| }); | ||
|
|
||
| it('shows help when no document and no STDIN are present', () => { | ||
| process.stdin.isTTY = true; | ||
| return expect(run('lint')).rejects.toContain('documents Location of JSON/YAML documents'); | ||
| }); | ||
|
|
||
| describe('when STDIN is present', () => { | ||
|
|
@@ -204,7 +207,7 @@ describe('lint', () => { | |
| }); | ||
|
|
||
| it('shows help if unknown format is passed', () => { | ||
|
There was a problem hiding this comment. Perhaps pop a test in here to verify something like There was a problem hiding this comment. we have it already haha :D When I made the following change https://github.com/stoplightio/spectral/pull/2044/files#diff-5c1bab693e4315f93ddc3bc536502fe23b536bbed6214ca5a093571db6389f24R14-R21, the test started to fail. |
||
| return expect(run('lint -f foo ./__fixtures__/empty-oas2-document.json')).rejects.toContain( | ||
| 'documents Location of JSON/YAML documents. Can be either a file, a glob or', | ||
| ); | ||
| }); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this a regression with yargs or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it wasn't, I just updated it while I was at it.