Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: monorepo #1679

Merged
merged 30 commits into from
Jun 22, 2021
Merged

chore: monorepo #1679

merged 30 commits into from
Jun 22, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jun 18, 2021

Closes #1614

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

I suggest to review the PR commit by commit.
There's a bit of noise that's a result of src -> packages move, but this took place in the first commit.

I introduced 2 breaking changes I was planning to do it anyway.

Note on the release - it's still not quite set up yet.
I'm planning to add a cron job to CircleCI to release some packages with a certain cadence.
However, to accomplish that, I'll need to integrate Lerna with semantic-versioning to make sure the process is automated and we don't need to do anything manually.
Ideally, rulesets and related are released weekly (assuming we have any code in place to publish), while Core / CLI are released on demand using the approval workflow in CircleCI

@P0lip P0lip added the chore label Jun 18, 2021
@P0lip P0lip force-pushed the chore/monorepo branch 6 times, most recently from 3cd1149 to 616e871 Compare June 21, 2021 17:35
@P0lip P0lip added the breaking Pull requests that introduce a breaking change label Jun 21, 2021
@P0lip P0lip marked this pull request as ready for review June 21, 2021 18:03
@P0lip P0lip requested review from marbemac and domagojk June 21, 2021 18:03
@mnaumanali94 mnaumanali94 self-requested a review June 21, 2021 18:29
Copy link
Contributor

@domagojk domagojk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@P0lip P0lip merged commit 43ed54c into develop Jun 22, 2021
@P0lip P0lip deleted the chore/monorepo branch June 22, 2021 13:31
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-cli-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-core-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-rulesets-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-runtime-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-functions-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-formats-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-parsers-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-ref-resolver-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Pull requests that introduce a breaking change chore released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectral v6 - monorepo
3 participants