Removed error catching on invalid attributes

The error catching made it hard to find the reason for "ignored" attributes. This change addresses the issues zircote#1267 and zircote#1162.

Instead of catching errors of non existing attribute classes, the existence of the class is checked before the attribute is tried to instantiate. This reveals invalid attribute definitions, but there won't be shown errors for attributes whose class definitions do not exist.

src/Analysers/AttributeAnnotationFactory.php

@@ -38,13 +38,13 @@ public function build(\Reflector $reflector, Context $context): array
         $annotations = [];
         try {
             foreach ($reflector->getAttributes() as $attribute) {
-                try {
+                if (class_exists($attribute->getName())) {
                     $instance = $attribute->newInstance();
                     if ($instance instanceof OA\AbstractAnnotation) {
                         $annotations[] = $instance;
                     }
-                } catch (\Error $e) {
-                    $context->logger->debug('Could not instantiate attribute: ' . $e->getMessage(), ['exception' => $e]);
+                } else {
+                    $context->logger->debug(sprintf('Could not instantiate attribute "%s", because class not found.', $attribute->getName()));
                 }
             }
 

tests/Analysers/AttributeAnnotationFactoryTest.php

@@ -8,6 +8,7 @@
 
 use OpenApi\Analysers\AttributeAnnotationFactory;
 use OpenApi\Tests\Fixtures\UsingAttributes;
+use OpenApi\Tests\Fixtures\InvalidPropertyAttribute;
 use OpenApi\Tests\OpenApiTestCase;
 
 /**
@@ -22,4 +23,15 @@ public function testReturnedAnnotationsCout(): void
         $annotations = (new AttributeAnnotationFactory())->build($rc, $this->getContext());
         $this->assertCount(1, $annotations);
     }
+
+    public function testErrorOnInvalidAttribute(): void
+    {
+        $instance = new InvalidPropertyAttribute();
+        $rm = new \ReflectionMethod($instance, 'post');
+
+        $this->expectException(\TypeError::class);
+        $this->expectExceptionMessage('OpenApi\Attributes\Property::__construct(): Argument #8 ($required) must be of type ?array, bool given');
+
+        (new AttributeAnnotationFactory())->build($rm, $this->getContext());
+    }
 }

tests/Fixtures/InvalidPropertyAttribute.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types=1);
+
+/**
+ * @license Apache 2.0
+ */
+
+namespace OpenApi\Tests\Fixtures;
+
+use OpenApi\Attributes as OA;
+
+class InvalidPropertyAttribute
+{
+    #[OA\Property(required: true)] // required has to be array or null
+    public function post()
+    {
+    }
+}