Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor rtl fixes #883

Merged
merged 6 commits into from
Apr 25, 2024
Merged

minor rtl fixes #883

merged 6 commits into from
Apr 25, 2024

Conversation

stnolting
Copy link
Owner

@stnolting stnolting commented Apr 24, 2024

  • removed non-ASCII characters from FPU comments (neorv32_cpu_cp_fpu.vhd)
  • fixed minor VHDL/GHDL issue (only relevant for older GHDL versions) in PMP mode select (case operand: "object type is not locally static")
  • fixed imprecise timing of first-transmitted UART TX bit (was not correctly synchronized with the UART baud clock)

@stnolting stnolting added the HW Hardware-related label Apr 24, 2024
@stnolting stnolting self-assigned this Apr 24, 2024
not synced to UART baud clock
circumvent GHDL error (older GHDL versions): "object type is not locally static"
@stnolting stnolting marked this pull request as ready for review April 24, 2024 19:37
@stnolting stnolting merged commit 8ca618c into main Apr 25, 2024
10 checks passed
@stnolting stnolting deleted the dev240424 branch April 25, 2024 05:08
Unike267 added a commit to Unike267/neorv32 that referenced this pull request May 2, 2024
According to stnolting#890
[bug] uart issue after stnolting#883 upd

The change is in neorv32_uart.vhd file
In 289 line:
From rx_engine.sreg(8 downto 1) to rx_engine.sreg(7 downto 0)
@Unike267 Unike267 mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HW Hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant