Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit #41eec5a introduced an error for me when synthesizing with Quartus or simulating with ModelSim/QuestaSim.
QuestaSim:
Quartus:
More specifically in neorv32_cpu_control.vhd#L136 the literal
HPM_CNT_WIDTH-32
evaluates to -32 if no HPMs are enabled and is no longer a valid natural type.I've added a quick fix for this by introducing a
cond_sel_int_f
function (hasn't that been there some time ago 🤔?). Fix works for me.