Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Update / rework SPI module #530

Merged
merged 12 commits into from
Mar 4, 2023
Merged

⚠️ Update / rework SPI module #530

merged 12 commits into from
Mar 4, 2023

Conversation

stnolting
Copy link
Owner

This PR is rework/update of the processor's SPI module.

  • ⚠️ change control register layout
  • ⚠️ remove configurable transmissions size, SPI operations are fixed to 8-bit
  • rework interrupt configuration mechanism (new style 😉)
  • improve blockRAM mapping/inference (using FIFO with synchronous read access)

@stnolting stnolting added HW Hardware-related optimization Make things faster, smaller and more efficient labels Mar 4, 2023
@stnolting
Copy link
Owner Author

stnolting commented Mar 4, 2023 •
edited
Loading

@akaeba Could you have a look at the demo_spi_irq demo program?

@stnolting stnolting marked this pull request as ready for review March 4, 2023 12:47
@akaeba
Copy link
Collaborator

akaeba commented Mar 4, 2023

@akaeba Could you have a look at the demo_spi_irq demo program?

yes i can check.

@akaeba
Copy link
Collaborator

akaeba commented Mar 4, 2023

Driver is changed, but evaluation in simulator is pending.

akaeba and others added 2 commits March 4, 2023 17:35
@akaeba
[sw/example/demo_spi_irq/main.c]: fix wrong usage of memset, memset a…
52a826f 
…ccepts size in byte, and sizeof returns umber of bytes. No element division necessary.
@stnolting
adjust SPI control register bits
146fca3
@stnolting
Copy link
Owner Author

Seems fine now.
Thanks for updating!

@stnolting stnolting merged commit 816137b into main Mar 4, 2023
@stnolting stnolting deleted the spi_update branch March 4, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HW Hardware-related optimization Make things faster, smaller and more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnolting @akaeba