🐛 fix buskeeper timeout error #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buskeeper raises an internal timeout error if an *external* access (via Wishbone) has the same access latency as there are maximum _internal_ timeout cycles
* stop timeout counter when it has reached zero * optimized size of timeout counter (1 bit less)
|
I think this is ready to be merged. What do you think @GideonZ? |
|
Hi Stephan!
Yes, I think you can safely merge this fix. It solves the crashes I was
seeing. I am still a bit confused to see the err_i signals fire during
normal operation. It makes it a bit difficult to trigger on such a fault in
SignalTap. But aside from that, this fix is very important, so please go
ahead and merge it.
Best regards,
Gideon
Message ID: ***@***.***>
… |
👍
Hmm, that's strange. Do you see this just during accesses via the external memory interface? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314. @GideonZ
The BUSKEEPER raises an internal timeout error if an external access (via Wishbone) has the same access latency as there are maximum internal timeout cycles (
max_proc_int_response_time_c).