Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setups] move to repo neorv32-setups #254

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Jan 9, 2022

As discussed in several issues, this is a proposal to move subdir setups to a different repository. For now, I created umarcor/neorv32-setups. However, I would expect to transfer it to stnolting/neorv32-setups or to neorv32/setups.

@stnolting
Copy link
Owner

Ok, we are doing this! 😉

Let me just check all the changes from this PR.

@umarcor
Copy link
Collaborator Author

umarcor commented Jan 11, 2022

As commented in stnolting/neorv32-setups#1, the most relevant changes are the modifications to CI. Workflows Containers and Implementation are moved to repo neorv32-setups, while Documentation, Processor and riscv-arch-test are kept here. The Windows workflow is split into Implementation and Processor.

Now, we need to deal with documentation. All the refs to the local setups subdir are broken. I don't know if you want to keep all the documentation subdir here, or if you want to move anything to neorv32-setups. I think there is no specific section about the setups in the datasheet or in the user guide; it's just some references. Therefore, I believe we could keep the docs untouched (just fix those refs). Later, we can discuss whether/how to add docs to the neorv32-setups repo. I'd like that to be cross-referenced to hdl/constraints, trabucayre/openFPGALoader and other projects in the ecosystem.

@stnolting
Copy link
Owner

Therefore, I believe we could keep the docs untouched (just fix those refs)

I agree. I will take care of fixing the broken links.

Btw, what about "cross repository" triggers? I think there are possibilities to trigger a workflow in one repository if there was a specific action in another repository. So something like: update rtl core in neorv32 -> trigger implementation workflow in neorv32-setups

@umarcor
Copy link
Collaborator Author

umarcor commented Jan 13, 2022

Btw, what about "cross repository" triggers? I think there are possibilities to trigger a workflow in one repository if there was a specific action in another repository. So something like: update rtl core in neorv32 -> trigger implementation workflow in neorv32-setups

Yes. That is trivial. It's a matter of doing an API call with curl. See https://github.com/ghdl/ghdl/blob/master/.github/workflows/Test.yml#L644-L650. The point is that the default token (${{ github.token }}) cannot trigger workflows across repos. You need a Personal Access Token (PAT) for that, and add it as a secret.

@umarcor
Copy link
Collaborator Author

umarcor commented Jan 13, 2022

After a second thought, since neorv32 is submoduled in neorv32-setups, we would also need to bump the submodule in neorv32-setups when the workflow is triggered from here. Hence, it might be desirable to use dependabot in neorv32-setups instead.

@stnolting
Copy link
Owner

Hence, it might be desirable to use dependabot in neorv32-setups instead.

Sounds reasonable. I have never used depnedabot before, but I will have a look at the docs.

@stnolting
Copy link
Owner

I think this is ready to be merged.

  • All references to setups are updated to point to the new repository.
  • Seems like we cannot resolve ecppack is crashing on Windows (MSYS2) neorv32-setups#11 at the moment. However, this is not a repository-related problem.
  • I think we should also set a new hardware version so this "major" change also appears in the version history and changelog.

@umarcor umarcor marked this pull request as ready for review January 18, 2022 10:44
@umarcor umarcor merged commit 016ff67 into stnolting:master Jan 18, 2022
@umarcor umarcor deleted the move-setups branch January 18, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants