Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slink variables rx_tmp_v and tx_tmp_v have wrong size #199

Closed
LeFl0w opened this issue Nov 4, 2021 · 1 comment · Fixed by #202
Closed

slink variables rx_tmp_v and tx_tmp_v have wrong size #199

LeFl0w opened this issue Nov 4, 2021 · 1 comment · Fixed by #202
Labels
bug Something isn't working as expected HW Hardware-related

Comments

@LeFl0w
Copy link

LeFl0w commented Nov 4, 2021

Hi,
both variables rx_tmp_v and tx_tmp_v have an upper bound equal to SLINK_NUM_RX-1 and SLINK_NUM_TX-1.

These variables are used as:

  •       irq_rx_o <= or_reduce_f(irq_rx_en and rx_tmp_v);
    
  •       irq_tx_o <= or_reduce_f(irq_tx_en and tx_tmp_v);
    

and refereing to definition of signals:

  •   signal irq_rx_en   : std_ulogic_vector(7 downto 0);
    
  •  signal irq_tx_en   : std_ulogic_vector(7 downto 0);
    

When doing the AND between the two of them with a SLINK_NUM_RX (or SLINK_NUM_TX) not equal to 8, the upper bound do not match.
This lead to a synthesis error on Vivdao 2021.1.

As soon as the vector is initialized entirely rx_tmp_v := (others => '0');
and tx_tmp_v := (others => '0');

it would be better to set the upper bound of both rx_tmp_v and tx_tmp_v to 7.

@stnolting
Copy link
Owner

Thanks for the hint!
I will have a look and fix that.

@stnolting stnolting added bug Something isn't working as expected HW Hardware-related labels Nov 4, 2021
stnolting added a commit that referenced this issue Nov 4, 2021
@stnolting stnolting linked a pull request Nov 4, 2021 that will close this issue
@stnolting stnolting removed a link to a pull request Nov 9, 2021
@stnolting stnolting linked a pull request Nov 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected HW Hardware-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants