Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: some dell machine /redfish/v1/systems without memeber@count #215

Merged
merged 1 commit into from
Nov 15, 2022
Merged

bugfix: some dell machine /redfish/v1/systems without memeber@count #215

merged 1 commit into from
Nov 15, 2022

Conversation

Sn0rt
Copy link
Contributor

@Sn0rt Sn0rt commented Nov 15, 2022

some dell machine not provider the [email protected] field

curl https://192.168.156.212/redfish/v1/Managers/iDRAC.Embedded.1 -u username:passwd --insecure -k --ciphers DEFAULT@SECLEVEL=1 | jq|grep FirmwareVersion
...
  "FirmwareVersion": "2.30.30.30",

so the system info as follow

{
  "@odata.context": "/redfish/v1/$metadata#Systems",
  "@odata.count": 1,
  "@odata.id": "/redfish/v1/Systems",
  "@odata.type": "#ComputerSystem.1.0.0.ComputerSystemCollection",
  "Description": "Collection of Computer Systems",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/System.Embedded.1"
    }
  ],
  "Name": "Computer System Collection"
}

and you can to compare with the stand format response( this body copy from another machine)

{
  "@odata.context": "/redfish/v1/$metadata#ComputerSystemCollection.ComputerSystemCollection",
  "@odata.id": "/redfish/v1/Systems",
  "@odata.type": "#ComputerSystemCollection.ComputerSystemCollection",
  "Description": "Collection of Computer Systems",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/System.Embedded.1"
    }
  ],
  "[email protected]": 1,
  "Name": "Computer System Collection"
}

Signed-off-by: Guohao Wang [email protected]

{
  "@odata.context": "/redfish/v1/$metadata#Systems",
  "@odata.count": 1,
  "@odata.id": "/redfish/v1/Systems",
  "@odata.type": "#ComputerSystem.1.0.0.ComputerSystemCollection",
  "Description": "Collection of Computer Systems",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/System.Embedded.1"
    }
  ],
  "Name": "Computer System Collection"
}

Signed-off-by: Guohao Wang <[email protected]>
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a Dell bug that should be filed. The Redfish spec even gives an example of the expected structure:

{
  "@odata.type": "#ComputerSystemCollection.ComputerSystemCollection",
  "Name": "Computer System Collection",
  "[email protected]": 4,
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/529QB9450R6"
    },
    {
      "@odata.id": "/redfish/v1/Systems/529QB9451R6"
    },
    {
      "@odata.id": "/redfish/v1/Systems/529QB9452R6"
    },
    {
      "@odata.id": "/redfish/v1/Systems/529QB9453R6"
    }
  ],
  "@odata.id": "/redfish/v1/Systems"
}

That said, this looks like it should be harmless, so for compatibility sake I think it should be fine to include.

@stmcginnis stmcginnis merged commit ed6dc5f into stmcginnis:main Nov 15, 2022
feuerrot pushed a commit to babiel/gofish that referenced this pull request May 24, 2023
…tmcginnis#215)

{
  "@odata.context": "/redfish/v1/$metadata#Systems",
  "@odata.count": 1,
  "@odata.id": "/redfish/v1/Systems",
  "@odata.type": "#ComputerSystem.1.0.0.ComputerSystemCollection",
  "Description": "Collection of Computer Systems",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/System.Embedded.1"
    }
  ],
  "Name": "Computer System Collection"
}

Signed-off-by: Guohao Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants