update GPIO 2 #346
Merged
update GPIO 2 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @richardeoin |
|
I am 👍 on this because I end up switching pins between pull-up and pull-down in certain situations and having the typestate makes this very annoying. |
|
It looks like you removed pull-up and floating from some examples but never
set the input type elsewhere. I feel like the examples should set the input
type to maintain previous functionality, especially for simple dev board
setups that often rely on the internal pull ups to set signal level of
buttons etc...
…On Tue, Apr 5, 2022, 11:11 AM Matt Ickstadt ***@***.***> wrote:
I am 👍 on this because I end up switching pins from pull-up to pull-down
in certain situations and having the typestate makes this very annoying.
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUS5FIGVKY7L7FHZRD5SFLVDRQ33ANCNFSM5SSO252Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
|
Oops, sorry about that. I was just looking at the diff which said nothing
about pull-up/pull-down, the initialization didn't change so I didn't
examine closely enough.
Looks great to me!
…On Tue, Apr 5, 2022, 11:26 AM Zgarbul Andrey ***@***.***> wrote:
It looks like you removed pull-up and floating from some examples but
never set the input type elsewhere.
into_pull_up_input never gone. It is just not present in type definition
now.
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUS5FNPM3PNG2TE24NIF5DVDRSULANCNFSM5SSO252Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Merged
|
rebased on #347 |
bors bot
added a commit
that referenced
this pull request
Apr 10, 2022
347: gpio rework r=richardeoin a=burrbull Functional part of #346 (without IntoAF restriction) Co-authored-by: Andrey Zgarbul <[email protected]> Co-authored-by: Zgarbul Andrey <[email protected]>
burrbull
force-pushed
the
gpio
branch
2 times, most recently
from
1bb4fa3 to
a1c77cc
Compare
|
rebased |
|
@burrbull Is this ready to merge? |
|
should be |
|
Ok thanks, let's merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.