-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flags #673
Flags #673
Conversation
d162bc6
to
f9879e2
Compare
@burrbull if i summarize, you removed single "listen_smth" in favor of "listen(DmaInterupts)" and now to check a flag you need to do stream.all_flags().is_smth() instead of stream.is_smth() |
note for bitflags, i wonder it it worse to check for better alternative. for example with bitflag 1.3.* you have garantee that unused bit are delete. let flags = A | B | C; however Bitbag may miss some functionnality compared to bitflags |
No. It should still work. |
Interesting. Have not see it before. |
lol, didn't see you gave a default implementation in the trait definition |
Looks like it is not marked as |
5e172d0
to
a808262
Compare
Looks like I've found good replacement. |
0f8d3d0
to
cf41240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, I like the new interface. Quite breaking, though.
Based on #666