Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete strictMode for JSONArray #887

Closed
stleary opened this issue Apr 13, 2024 · 4 comments
Closed

Complete strictMode for JSONArray #887

stleary opened this issue Apr 13, 2024 · 4 comments

Comments

@stleary
Copy link
Owner

stleary commented Apr 13, 2024 •
edited
Loading

Garbage chars at the end of JSONArray docs are still allowed in strict mode. This needs to be fixed.

Here is a list of examples of JSON text strings that should be allowed in default mode, but not in strict mode. This is not an exhaustive list. Unit tests should confirm expected behavior when strictMode is true and false.

"[]asdf",
"[]]",
"[]}",
"[][",
"[]{",
"[],",
"[]:",
"[],[",
"[],{"

Note: It should not be necessary for the code to check for specific trailing chars; strict mode is violated if parsing is completed and there are still chars left in the JSONTokener instance.
@stleary stleary changed the title Completed strictMode for JSONArray Complete strictMode for JSONArray Apr 13, 2024
@rikkarth
Copy link
Contributor

rikkarth commented Apr 14, 2024 •
edited
Loading

Hi @stleary would you please be able to provide one or two examples?

@stleary
Copy link
Owner Author

stleary commented Apr 14, 2024

Description updated

@rikkarth
Copy link
Contributor

image

rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 14, 2024
@rikkarth
fix(stleary#887): complete strictMode for JSONArray
fe597d2
@rikkarth rikkarth mentioned this issue Apr 14, 2024
Merged
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 14, 2024
@rikkarth
fix(stleary#887): corrected small typo
ce074e9
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 21, 2024
@rikkarth
fix(stleary#887): double array breaking JSONTokener.nextValue
3dcd5b2 
change(stleary#887): input validation
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 21, 2024
@rikkarth
fix(stleary#887): small typo
0bace72
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 23, 2024
@rikkarth
fix(stleary#887): regression parsing array with non-string and boolea…
7cc1948 
…n values
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 23, 2024
@rikkarth
chore(stleary#887): clean up parsedUnquotedText implementation
ce13ebd
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 23, 2024
@rikkarth
fix(stleary#887): allow null value strict mode
898dd5a
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 23, 2024
@rikkarth
chore(stleary#887): signature minor edit
879579d
@stleary stleary mentioned this issue Apr 28, 2024
Closed
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 28, 2024
@rikkarth
fix(stleary#887): regressions, unit tests
1ae43bd 
- JSONArray now evaluates EOF accordingly for empty Array inputs.
- JSONTokener fixed indentation
- externalized two JSONMLTest cases
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue Apr 28, 2024
@rikkarth
fix(stleary#887): unit tests, uncommented tests after fix
48dfeb8
rikkarth added a commit to rikkarth/JSON-java-fork that referenced this issue May 19, 2024
@rikkarth
chore(stleary#887): JSONParserConfiguration strictMode true flag cleanup
a8ab79e
stleary added a commit that referenced this issue May 21, 2024
@stleary
Merge pull request #888 from rikkarth/fix/887
14f7127 
fix(#887): complete strictMode for JSONArray
@stleary
Copy link
Owner Author

stleary commented May 21, 2024

Closing due to feature accepted and merged.

@stleary stleary closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stleary @rikkarth