Feat/add model systems to assets #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-sand-0da50520f-89.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-sand-0da50520f-89.eastus2.azurestaticapps.net |
ajswis
approved these changes
Dec 1, 2021
jamesmadson
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
@sawiggins the model systems logo isn't loading for me from its address: https://victorious-sand-0da50520f-89.eastus2.azurestaticapps.net/assets/images/icon-model-systems.png
Other than making sure that will check out, LGTM! Thanks!
|
I'm going to separate out the assets package from the Fractal stuff into separate PRs for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke this out into a couple of PRs since adding this asset should be pulled into the other for the React navbar and footer to work properly. Updating fractal can happen at any point in the workflow since we do not release it (open to discussion if anyone has opinions on this though). We had an svg but not a png for model systems, so this PR adds the png file and updates the Fractal portion.
@claymcleod I bumped this to rc-4 but am wondering if we were waiting on anything in particular to move it out of the RC stage. Thoughts?
Additionally, I had problems compiling the scss through parcel bundler but pinning @babel/preset-env to 7.13.8 seems to have resolved it (same issue and used fix as described in this issue)
Since this PR involves adding the model systems icon to the header and footer even in Fractal, it will not be released until we have been given a greenlight from IS that we are ready to release the new app.