Debounce adapter config option #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hopsoft
requested changes
Jun 8, 2023
hopsoft
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
Description
This allows to set a different debounce adapter than the built-in one, in preparation to building one with https://github.com/hopsoft/composite_cache_store/
Initially I wanted to move the
MemoryCacheDebounceAdaptertolib/cable_ready/updatable/memory_cache_debounce_adapter.rb, but that again resulted in weird Zeitwerk issues when requiring it that led nowhere. That's why I opted into defining the default adapter in a config hook.Eventually we'll want to move the whole updatable cod from
app/tolib/.Checklist