Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Helper to ViewHelper so Rails will include it correctly #224

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Rename Helper to ViewHelper so Rails will include it correctly #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee86f6b
Rename Helper to ViewHelper so it works properly
erlingur Nov 13, 2022
e820be8
Fix tests after renaming Helper to ViewHelper
erlingur Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/cable_ready/helper.rb → app/helpers/cable_ready/view_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

module CableReady
module Helper
module ViewHelper
include CableReady::Compoundable
include CableReady::StreamIdentifier

Expand Down
2 changes: 1 addition & 1 deletion lib/cable_ready_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

module CableReadyHelper
def self.included(base)
raise "`CableReadyHelper` was renamed to `CableReady::Helper`"
raise "`CableReadyHelper` was renamed to `CableReady::ViewHelper`"
end
end
6 changes: 3 additions & 3 deletions test/lib/cable_ready/helper_test.rb → test/lib/cable_ready/view_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

require "test_helper"

class CableReady::HelperTest < ActionView::TestCase
include CableReady::Helper
class CableReady::ViewHelperTest < ActionView::TestCase
include CableReady::ViewHelper

# stream_from

Expand Down Expand Up @@ -62,6 +62,6 @@ class RaiseHelperTest # standard:disable Lint/ConstantDefinitionInBlock
RaiseHelperTest.new
end

assert_equal "`CableReadyHelper` was renamed to `CableReady::Helper`", expection.message
assert_equal "`CableReadyHelper` was renamed to `CableReady::ViewHelper`", expection.message
end
end