Warning in Ruby 3.0

[thomasklemm]

After upgrading to Ruby 3.0, the following warning gets printed when running system specs right before the first reflex invocation in a spec example:

.../ruby/gems/3.0.0/gems/cable_ready-4.5.0/lib/cable_ready/channel.rb:14: 
warning: finalizer references object to be finalized

Link to the line in question.

ObjectSpace.define_finalizer self, -> { CableReady.config.delete_observer config_observer }

[marcoroth]

Hey @thomasklemm, thank you for reporting this issue!

Do you have a clue how that should look like in Ruby 3?

To be honest I don't fully grok what needs to be changed in order to be ready for Ruby 3.

The code was introduced in #96. Maybe @hopsoft can expand on it.

[thomasklemm]

It looks like the warning gets raised since self is being passed to ObjectSpace.define_finalizer, according to the warning spec'd here. Not sure what's best for Ruby 3.0.

Edit:
The warning came to be through this discussion and PR: Feature #15794: Warn in verbose mode on defining a finalizer that captures the object

Edit 2:
Actually this seems to be the last PR bringing the warning in: ruby/ruby#3444

Looks like the proc holding a reference to config_observer (which self is assigned to`) could be the issue. Not really sure though what to do.

[n-rodriguez]

This might be a solution : https://www.mikeperham.com/2010/02/24/the-trouble-with-ruby-finalizers/

[leastbad]

@thomasklemm could you try out the https://github.com/hopsoft/cable_ready/tree/hopsoft/finalize branch from #116 and confirm that it addresses the issues you've seen?

[alexander-makarenko]

@leastbad Indeed, #116 solves the problem.

[thomasklemm]

@leastbad #116 works, the warnings are gone when using the PR branch 👍