Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: sync gyp code base with node-gyp repo #24

Merged
merged 1 commit into from
Feb 21, 2020
Merged

tools: sync gyp code base with node-gyp repo #24

merged 1 commit into from
Feb 21, 2020

Conversation

sthagen
Copy link
Owner

@sthagen sthagen commented Feb 21, 2020

PR-URL: nodejs#30563
Reviewed-By: Ujjwal Sharma [email protected]
Reviewed-By: Christian Clauss [email protected]
Reviewed-By: Ruben Bridgewater [email protected]
Reviewed-By: Rich Trott [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@targos
tools: sync gyp code base with node-gyp repo
cf00961 
PR-URL: #30563
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@sthagen sthagen merged commit 66ef984 into sthagen:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sthagen @targos