Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate configuring ember-cli-memory-leak-detector via config/environment.js #48

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Deprecate configuring ember-cli-memory-leak-detector via config/environment.js #48

merged 2 commits into from
Oct 26, 2021

Conversation

bertdeblock
Copy link
Contributor

Since all the work happens at build time, we can ask the user to define the configuration in ember-cli-build.js instead. This also prevents the configuration from being added to the app's meta tag even when ember-cli-memory-leak-detector is disabled.

Closes #39.

@bertdeblock
Copy link
Contributor Author

@steveszc Any pointers on getting CI to pass? I could be wrong, but it seems that the test apps are using a published version of ember-cli-memory-leak-detector during CI? If that's the case, then I'm not sure how I can make CI pass here.

@steveszc
Copy link
Owner

@bertdeblock oh nice catch, I think you are probably right. Feel free to push another commit to this branch that uses '*' as the version number for ember-cli-memory-leak-detector dependency in the test packages. I think that is probably the right approach here... we could also update the version number in the test packages, but that could easily get out of date again.

@bertdeblock
Copy link
Contributor Author

Okay, updated those versions and now (hopefully) CI should pass. I've noticed that running the test suite locally sometimes fails and sometimes it doesn't, even for the main branch. Unclear to me as to why this happens.

@bertdeblock
Copy link
Contributor Author

@steveszc Mind approving the workflow?

@steveszc
Copy link
Owner

@bertdeblock Looks like we're green, I'll approve and merge. I also noticed the flakiness of the test suite recently. Not sure exactly what is going on there but definitely something I need to look in to. It may be related to the Qunit issues that have been reported #49

Copy link
Owner

@steveszc steveszc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @bertdeblock!
Fixes #39

@steveszc steveszc merged commit 7bbbb32 into steveszc:main Oct 26, 2021
@bertdeblock
Copy link
Contributor Author

Thank you @steveszc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not put ember-cli-memory-leak-detector in <meta name="frontend/config/environment" ...
2 participants